properly throw errors so Catch node can handle them. #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently dashdb node doesn't properly handle errors - it logs the error on console, then "swallows" it.
Impact: when errors happened in dashdb nodes, the flow simply terminates and there is no way for flow developer to handle error and recover.
The proper way to handle errors as documented in node-red official docs:
Handling errors
If the function encounters an error that should halt the current flow, it should return nothing. To trigger a Catch node on the same tab, the function should call node.error with the original message as a second argument:
This PR updates dashdb code to pass in
msg
in allnode.error()
calls so that Catch node will be able to catch those errors.